[ https://issues.apache.org/jira/browse/MAPREDUCE-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790581#action_12790581 ]
rahul k singh commented on MAPREDUCE-1143: ------------------------------------------ [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories. [exec] [exec] [exec] [exec] [exec] ====================================================================== [exec] ====================================================================== [exec] Finished build. [exec] ====================================================================== [exec] ====================================================================== [exec] [exec] This fix doesnt have testcase , as it requires a significant change , we have provided for the trunk , manual testing is done to make sure that things are fine. for eclipse classpath its a known issue for 20 internal patch. > runningMapTasks counter is not properly decremented in case of failed Tasks. > ---------------------------------------------------------------------------- > > Key: MAPREDUCE-1143 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1143 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 0.20.1 > Reporter: rahul k singh > Assignee: rahul k singh > Priority: Blocker > Fix For: 0.21.0 > > Attachments: MAPRED-1143-1.patch, MAPRED-1143-2.patch, > MAPRED-1143-2.patch, MAPRED-1143-3.patch, MAPRED-1143-4.patch, > MAPRED-1143-5.patch.txt, MAPRED-1143-6.patch, MAPRED-1143-7.patch, > MAPRED-1143-ydist-1.patch, MAPRED-1143-ydist-2.patch, > MAPRED-1143-ydist-3.patch, MAPRED-1143-ydist-4.patch, > MAPRED-1143-ydist-5.patch, MAPRED-1143-ydist-6.patch, > MAPRED-1143-ydist-7.patch, MAPRED-1143-ydist-8.patch.txt, > MAPRED-1143-ydist-9.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.