[
https://issues.apache.org/jira/browse/MAPREDUCE-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790607#action_12790607
]
Eli Collins commented on MAPREDUCE-1165:
----------------------------------------
+1
Patch looks good. Using this C99 ism is should be fine on linux, solaris and
osx. I tested the patch on linux after applying MAPREDUCE-1251.
> SerialUtils.hh: __PRETTY_FUNCTION__ is a GNU extension and not portable
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-1165
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1165
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Allen Wittenauer
> Attachments: MAPREREDUCE-1165.patch
>
>
> SerialUtils.hh uses __PRETTY_FUNCTION__ to print the name of the function
> during an assertion. That is a GNU extension and is not portable across
> compilers. [C99 defines __func__, which should probably be used instead.]
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
