[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795243#action_12795243
 ] 

Kay Kay commented on MAPREDUCE-1343:
------------------------------------

I happened to file this bug - since one of the test cases failed ( 
MAPREDUCE-1334  ) due to the auto-generation of _SUCCESS .  While I had 
submitted a patch for that , by explicitly setting the configuration property - 
mapreduce.fileoutputcommitter.marksuccessfuljobs to be false-  I don't think it 
is a great idea for the rest of the system to exactly know the property string 
name. 

If package-protected has to be maintained - then may be we can add another 
setter method along the lines of - 

  private void setMarkOutputDir(JobConf conf, boolean flag) {
    conf.setBoolean(SUCCESSFUL_JOB_OUTPUT_DIR_MARKER, flag);
  }

and other piece of code can use this, until we make a decision. 

> Scope Change - FileOutputCommitter # SUCCESSFUL_JOB_OUTPUT_DIR_MARKER, 
> package default to public 
> -------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1343
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1343
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Kay Kay
>             Fix For: 0.21.0
>
>         Attachments: MAPREDUCE-1343.patch
>
>
> Being a configuration property - it should be public static for apps to set 
> /reset the property as opposed to hardcoding the string. 
> Scope changed from package default to public. 
> Also - enhanced with javadocs around the same. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to