[
https://issues.apache.org/jira/browse/MAPREDUCE-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800041#action_12800041
]
Arun C Murthy commented on MAPREDUCE-1316:
------------------------------------------
Minor comments/nits:
{code}
- taskidToTIPMap.remove(taskid);
-
- LOG.debug("Removing task '" + taskid + "'");
+ if (taskidToTIPMap.remove(taskid) != null) {
+ LOG.info("Removing task '" + taskid + "'");
+ }
{code}
This adds a lot more logging? Is it necessary or useful?
{code}
- LOG.info("Removed completed task '" + taskid + "' from '" +
- taskTracker + "'");
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Removed marked completed task '" + taskid + "' from '" +
+ taskTracker + "'");
+ }
{code}
This removes some logs... you don't think they would be useful?
{code}
+ LOG.info("Job " + jobId + " added successfully for user '"
+ + job.getJobConf().getUser() + "' to queue '"
+ + job.getJobConf().getQueueName() + "'");
{code}
Is this log necessary? I don't see how this is relevant to this patch.
----
Finally - can you please share some details on how this patch has helped to fix
the observed bugs? Thanks!
> JobTracker holds stale references to retired jobs via unreported tasks
> -----------------------------------------------------------------------
>
> Key: MAPREDUCE-1316
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1316
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: jobtracker
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Priority: Blocker
> Attachments: mapreduce-1316-v1.11.patch,
> mapreduce-1316-v1.13-branch20-yahoo.patch,
> mapreduce-1316-v1.14-branch20-yahoo.patch,
> mapreduce-1316-v1.14.1-branch20-yahoo.patch, mapreduce-1316-v1.7.patch
>
>
> JobTracker fails to remove _unreported_ tasks' mapping from _taskToTIPMap_ if
> the job finishes and retires. _Unreported tasks_ refers to tasks that were
> scheduled but the tasktracker did not report back with the task status. In
> such cases a stale reference is held to TaskInProgress (and thus
> JobInProgress) long after the job is gone leading to memory leak.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
