[
https://issues.apache.org/jira/browse/MAPREDUCE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Amareshwari Sriramadasu updated MAPREDUCE-899:
----------------------------------------------
Attachment: patch-899-2.txt
Patch incorporating most of the review comments.
bq. TTConfig.TT_TASK_CONTROLLER_GROUP seems to be only for internal use.
I dont think it is only for internal use. Though currently it is read only in
TaskController, I think it is like any other configuration. After
MAPREDUCE-849, it should to be categorized into one the categories :
Cluster/JobTracker/TaskTracker/Client/Job. So, this goes into TaskTracker. Does
that make sense?
bq. taskcontroller.cfg: Can you modify the comment for
mapreduce.tasktracker.taskcontroller.group to be "The group owner of the task
controller binary"
With the above explanation, I think this change is not needed. The comment is
in consistent with other config comments.
bq. Instead of giving the default value of
System.getProperty(TASKCONTROLLER_PATH)+ "/task-controller" to
taskControllerExePath, you can use setTaskControllerExe() whenever needed.
Now that TaskTracker constructor (which calls TaskController.setup()) requires
this value to be set, we cannot postpone setting of taskControllerExePath after
the constructor (as earlier). Since default value can be constructed
statically, there is no harm setting the default value for
taskControllerExePath.
bq. For general ClusterWithLinuxTaskController tests, we can disable the binary
checks by overriding LinuxTaskController.setup() method and can then simply
generate the configuration file after the cluster starts so that further checks
done when tasks are launched can go smoothly.
I have done this by overriding LinuxTaskController.setup() method to set set
task-controller group and writing the configuration file and then calling
super.setup().
bq. To verify the checks during TT startup, we can add simple unit tests which
just start the TT with/without group name and with invalid group name.
Added this unit test.
> When using LinuxTaskController, localized files may become accessible to
> unintended users if permissions are misconfigured.
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-899
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-899
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Reporter: Vinod K V
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-899-20090828.txt, patch-899-1.txt,
> patch-899-2.txt, patch-899.txt
>
>
> To enforce the accessibility of job files to only the job-owner and the
> TaskTracker, as per MAPREDUCE-842, it is _trusted_ that the setuid/setgid
> linux TaskController binary is group owned by a _special group_ to which only
> TaskTracker belongs and not just any group to which TT belongs. If the trust
> is broken, possibly due to misconfiguration by admins, the local files become
> accessible to unintended users, yet giving false sense of security to the
> admins.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
