[ 
https://issues.apache.org/jira/browse/MAPREDUCE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803607#action_12803607
 ] 

Vinod K V commented on MAPREDUCE-899:
-------------------------------------

The code changes all look good now. Only minor finishing touches needed for the 
documentation:
 - mapreduce.tasktracker.taskcontroller.group is an unusual configuration item 
documented in mapred-default.xml. It is not directly used by the TT daemon 
itself, but instead by the task-controller binary and that to only when 
LinuxTaskController is configured for the TT. I think we should state this 
clearly in mapred-default.xml. Also we should point to the taskcontroller.cfg 
file where it is actually needed to be configured.
 - cluster_setup.xml changes also need some update.  We should say that 
mapreduce.tasktracker.taskcontroller.group needs to be configured in 
mapred-site.xml and taskcontroller.cfg. For better organization, we may move 
taskcontroller.cfg to a sub-section and refer to that. Also the special group 
may now contain other members like admin users besides TT unlike before. Though 
having job-submitters themselves as other members will compromise security. We 
should change the description to reflect this. The example that follows should 
also be inline with this. Minor typo in 
mapreduce.tasktracker.taskcontroller.group description in taskcontroller.cfg 
section - it should be "TaskTracker should belong *to* this group"

> When using LinuxTaskController, localized files may become accessible to 
> unintended users if permissions are misconfigured.
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-899
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-899
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tasktracker
>            Reporter: Vinod K V
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-899-20090828.txt, patch-899-1.txt, 
> patch-899-2.txt, patch-899.txt
>
>
> To enforce the accessibility of job files to only the job-owner and the 
> TaskTracker, as per MAPREDUCE-842, it is _trusted_ that the  setuid/setgid 
> linux TaskController binary is group owned by a _special group_ to which only 
> TaskTracker belongs and not just any group to which TT belongs. If the trust 
> is broken, possibly due to misconfiguration by admins, the local files become 
> accessible to unintended users, yet giving false sense of security to the 
> admins.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to