[ https://issues.apache.org/jira/browse/MAPREDUCE-1464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830457#action_12830457 ]
Kan Zhang commented on MAPREDUCE-1464: -------------------------------------- I looked at the patch again and found that there is no null checking at the caller (per your HADOOP-6510.21.patch). I suggestion you return an empty ugi instead of null for getUser() method (do the same in HDFS-935) to reduce the chance of NullPointerException at runtime. > In JobTokenIdentifier change method getUsername to getUser which returns UGI > ---------------------------------------------------------------------------- > > Key: MAPREDUCE-1464 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1464 > Project: Hadoop Map/Reduce > Issue Type: New Feature > Reporter: Jitendra Nath Pandey > Attachments: MR-1464.1.patch > > > The TokenIdentifier interface has changed in HADOOP-6510. This jira tracks > corresponding change in MR. The only change is that in JobTokenIdentifier > getUsername method will be changed to getUser that will return ugi. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.