[ https://issues.apache.org/jira/browse/MAPREDUCE-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12830500#action_12830500 ]
Hemanth Yamijala commented on MAPREDUCE-1435: --------------------------------------------- A few minor nits: - Typo: contets in comments of ClusterWithLinuxTaskController. - checkPermissionsOnPrivateDistCache: Do we expect at least one of the directories to have the file. If yes, we should check for that; otherwise we will mask errors. Similarly for checkPermissionsOnPublicDistCache - checkPublicFilePermissions seems to be verifying permissions only for others. Should we also check permissions for owner and group ? - Comments in createSubDirsAndSymLinks should be dir1/subDir, dir1/file - Do we need DefaultTaskController.enableTaskForCleanup to give rwx access to group ? Setting the permissions for user should be sufficient, I think. > symlinks in cwd of the task are not handled properly after MAPREDUCE-896 > ------------------------------------------------------------------------ > > Key: MAPREDUCE-1435 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1435 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: tasktracker > Affects Versions: 0.22.0 > Reporter: Amareshwari Sriramadasu > Assignee: Ravi Gummadi > Fix For: 0.22.0 > > Attachments: 1435.patch, 1435.v1.patch, 1435.v2.patch > > > With JVM reuse, TaskRunner.setupWorkDir() lists the contents of workDir and > does a fs.delete on each path listed. If the listed file is a symlink to > directory, it will delete the contents of those linked directories. This > would delete files from distributed cache and jars directory,if > mapred.create.symlink is true. > Changing ownership/permissions of symlinks through ENABLE_TASK_FOR_CLEANUP > would change ownership/permissions of underlying files. > This is observed by Karam while running streaming jobs with DistributedCache > and jvm reuse. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.