[
https://issues.apache.org/jira/browse/MAPREDUCE-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834104#action_12834104
]
Chris Douglas commented on MAPREDUCE-1414:
------------------------------------------
The test harness, I'd argue, is not more robust because there is a log when the
test fails for ambiguous reasons. I tried running this test on my laptop, it
failed because the job took more than a minute, and it was still unclear why-
or whether- that was a problem. The log artifact was just as useless as nothing
and the proposed patch doesn't change that; it makes an already flaky test even
less reliable by introducing a failure case that is not implicit in what the
test is validating.
If the test is flaky, the framework and/or the test are flawed. The current
patch proposes to fix neither one.
> TestRecoveryManager can spin waiting for a job to be half done
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-1414
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1414
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: test
> Affects Versions: 0.22.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1414.patch
>
>
> This is something I've seen: the TestRecoveryManager spinning forever waiting
> for a job to get half done. The test runner will eventually kill it, but that
> loses any log and chance of finding the problem.
> Solution: have a timeout on how long you wait for the job
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
