[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834136#action_12834136
 ] 

Rajesh Balamohan commented on MAPREDUCE-1354:
---------------------------------------------

In the latest patch, getTaskCompletionEvents is using synchronized(this) I 
believe.

It has to be on "synchronized (jobs) {"

public TaskCompletionEvent[] getTaskCompletionEvents(
      JobID jobid, int fromEventId, int maxEvents) throws IOException{

     JobInProgress job = null;
     synchronized (jobs) {
      job = this.jobs.get(jobid);
     }
      if (null != job) {
        return isJobInited(job) ?
            job.getTaskCompletionEvents(fromEventId, maxEvents) :
            TaskCompletionEvent.EMPTY_ARRAY;
      }
      return completedJobStatusStore.readJobTaskCompletionEvents(jobid, 
fromEventId, maxEvents);
  }

> Refactor JobTracker.submitJob to not lock the JobTracker during the HDFS 
> accesses
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1354
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1354
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>            Reporter: Devaraj Das
>            Assignee: Arun C Murthy
>            Priority: Critical
>         Attachments: MAPREDUCE-1354_yhadoop20.patch, 
> MAPREDUCE-1354_yhadoop20.patch, MAPREDUCE-1354_yhadoop20.patch, 
> MAPREDUCE-1354_yhadoop20.patch, MAPREDUCE-1354_yhadoop20.patch, 
> MAPREDUCE-1354_yhadoop20.patch
>
>
> It'd be nice to have the JobTracker object not be locked while accessing the 
> HDFS for reading the jobconf file and while writing the jobinfo file in the 
> submitJob method. We should see if we can avoid taking the lock altogether.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to