[
https://issues.apache.org/jira/browse/MAPREDUCE-1493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837114#action_12837114
]
Ravi Gummadi commented on MAPREDUCE-1493:
-----------------------------------------
Some more comments:
(6) JobACLs.java In comment, change "specify" to "specified". Also it says
'superuser/supergroup of the "jobTracker"' --- superuser/supergroup will not be
specific to JT after 1455 and it is cluster level.
(7) Error messages displayed when authorization fails are not having the
job-view-ACLs configured for the job. Please add the message obtained from
Acces sControlException in the error message.
(8) In TestWebUIAuthorization.java, the name of existing method
testWebUIAuthorization() is changed to TestWebUIAuthorization(). May be you did
it for your testing sothat the method won't run. Please change the name back. A
cooment refers to "jobdetails.jsp" --- should instead be
"jobdetailshistory.jsp". props.setProperty(JSPUtil.PRIVATE_ACTIONS_KEY,
"true"); is not needed for testing history related stuff.
(9) Don't we want to support viewing of older history files ? With older
history files(where job ACLs are not there), JSPUtil.getJobInfo() gets NPE
because JobSubmittedEvent.getJobACLs() gets NPE. Should we allow viewing of
older history files assuming that view access exists for those jobs for all
users ?
(10) taskstatshistory.jsp, taskdetailshistory.jsp and TaskLogServlet can be
validated in the testcase.
(11) In rumen, in Job20LineHistoryEventEmitter.java, from the parsed line of
history file, jobACLs are not read but empty ACLs are written to. I guess we
need to build ACLs from the parsedLine of history.
(12) In all history related jsps, unnecessary import of
"org.apache.hadoop.security.UserGroupInformation" can be removed. Also
unnecesary line "String user = request.getRemoteUser();" can be removed.
(13) Very minor: Indentation of line "JSPUtil.checkAccess...." in
jobdetailshistory.jsp
(14) We wanted to remove the variable "conf"(which is doing just new
Configuration()) from JSPUtil.java in this patch. Can you do it here ? We can
get the CACHE_SIZE using jobTracker.conf.get(JT_JOBHISTORY_CACHE_SIZE) in
getJobInfo() ?
(15) Am not sure if passing of rumen tests is good enough for this patch. Do we
need any additional testing ?
> Authorization for job-history pages
> -----------------------------------
>
> Key: MAPREDUCE-1493
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1493
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: jobtracker, security
> Reporter: Vinod K V
> Assignee: Vinod K V
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1493-20100222.1.txt
>
>
> MAPREDUCE-1455 introduces authorization for most of the Map/Reduce jsp pages
> and servlets, but left history pages. This JIRA will make sure that
> authorization checks are made while accessing job-history pages also.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
