[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841614#action_12841614
 ] 

Todd Lipcon commented on MAPREDUCE-1120:
----------------------------------------

bq. If polling intervals are job-level configuration parameters, Job. 
getCompletionPollInterval(conf) and Job.getProgressPollInterval(conf) should be 
not static methods and should not take configuration as the parameter. The 
methods should read the values from Job's conf directly. 

OK. Do we need to maintain compatibility on these static functions, since 
they're a public API? (eg mark the static ones deprecated, then make non-static 
ones that forward to the static ones for now)

> JobClient poll intervals should be job configurations, not cluster 
> configurations
> ---------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1120
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1120
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mapreduce-1120.txt
>
>
> Job.waitForCompletion gets the poll interval from the Cluster object's 
> configuration rather than its own Job configuration. This is 
> counter-intuitive - Chris and I both made this same mistake working on 
> MAPREDUCE-64, and Aaron agrees as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to