[
https://issues.apache.org/jira/browse/MAPREDUCE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842240#action_12842240
]
Hemanth Yamijala commented on MAPREDUCE-1422:
---------------------------------------------
Amar,
I suppose I might have been misleading using the term 'test case'. I did not
mean test case as a separate class. I meant it as a separate test method in the
same class TestTrackerTrackerLocalization. The motivation is to keep unit tests
focused on testing one thing at a time, so it will be easier to find what
failed when there is a failure. Currently since the existing test methods that
you modified all test task cleanup, I suggested you move the code to a separate
test method focusing on testing job cleanup.
If we do this, we don't need TestJobLocalDirCleanupWithLinuxTaskController,
right ?
Does this make sense now ?
> Changing permissions of files/dirs under job-work-dir may be needed sothat
> cleaning up of job-dir in all mapred-local-directories succeeds always
> -------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1422
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Reporter: Ravi Gummadi
> Assignee: Amar Kamat
> Attachments: mapreduce-1422-test-v1.0.patch,
> mapreduce-1422-v1.4.2.patch
>
>
> After MAPREDUCE-896, if LinuxTaskController is set in config, task-controller
> binary is launched for changing permissions of taskAttemptDir and taskWorkDir
> before cleaning up of these directories sothat cleanup will be succeeded even
> if user had created files/dirs under taskAttemptDir or taskWorkDir with
> non-writable permissions. Users can't create files/dirs under job-dir
> directly as we set 2570 for job-dir. But as job-work-dir has 2770 permissions
> and user can create files/dirs under job-work-dir with non-writable
> permissions, Changing permissions of files/dirs under job-work-dir may be
> needed sothat cleaning up of job-dir in all mapred-local-directories succeeds
> always.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
