[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846326#action_12846326
 ] 

Hadoop QA commented on MAPREDUCE-1320:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12438126/MAPREDUCE-1320.patch
  against trunk revision 923907.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: 
http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/347/console

This message is automatically generated.

> StringBuffer -> StringBuilder occurence 
> ----------------------------------------
>
>                 Key: MAPREDUCE-1320
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1320
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.22.0
>            Reporter: Kay Kay
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1320.patch, MAPREDUCE-1320.patch
>
>
> A good number of toString() implementations use StringBuffer when the 
> reference clearly does not go out of scope of the method and no concurrency 
> is needed. Patch contains replacing those occurences from StringBuffer to 
> StringBuilder. 
> Created against map/reduce project trunk . 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to