[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846686#action_12846686
 ] 

Tamas Sarlos commented on MAPREDUCE-1593:
-----------------------------------------

Re: -1 tests included: MAPREDUCE-1306 introduced a test case, 
TestRandomSeedGenerator.java. The current patch does not change the API of 
RandomSeedGenerator.java. 

> [Rumen] Improvements to random seed generation 
> -----------------------------------------------
>
>                 Key: MAPREDUCE-1593
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1593
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Tamas Sarlos
>            Assignee: Tamas Sarlos
>            Priority: Trivial
>             Fix For: 0.21.0, 0.22.0
>
>         Attachments: MAPREDUCE-1593-20100311-dup.patch, 
> MAPREDUCE-1593-20100311.patch
>
>
> RandomSeedGenerator introduced in MAPREDUCE-1306 could be more efficient by 
> reusing the MD5 object across calls. Wrapping the MD5 in a ThreadLocal makes 
> the call thread safe as well. Neither of these is an issue with the current 
> client, the mumak simulator, but the changes are small and make the code more 
> useful in the future. Thanks to Chris Douglas for the suggestion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to