[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850093#action_12850093
 ] 

Amareshwari Sriramadasu commented on MAPREDUCE-1466:
----------------------------------------------------

A couple of comments:
# The string constant NUM_INPUT_FILES need not be defined in 
org.apache.hadoop.mapred.FileInputFormat. It can use the one from 
org.apache.hadoop.mapreduce.lib.input.FileInputFormat
# Can you add the unit test in 
org.apache.hadoop.mapreduce.lib.input.TestFileInputFormat also?


> FileInputFormat should save #input-files in JobConf
> ---------------------------------------------------
>
>                 Key: MAPREDUCE-1466
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1466
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 0.22.0
>            Reporter: Arun C Murthy
>            Assignee: Arun C Murthy
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: MAPREDUCE-1466_yhadoop20-1.patch, 
> MAPREDUCE-1466_yhadoop20-2.patch, MAPREDUCE-1466_yhadoop20-3.patch, 
> MAPREDUCE-1466_yhadoop20.patch, mr-1466-trunk-v1.patch, mr-1466-trunk-v2.patch
>
>
> We already track the amount of data consumed by MR applications 
> (MAP_INPUT_BYTES), alongwith, it would be useful to #input-files from the 
> client-side for analysis. Along the lines of MAPREDUCE-1403, it would be easy 
> to stick in the JobConf during job-submission.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to