[
https://issues.apache.org/jira/browse/MAPREDUCE-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853316#action_12853316
]
Amareshwari Sriramadasu commented on MAPREDUCE-1662:
----------------------------------------------------
bq. -1 tests included.
No new tests added because patch removes dead code.
bq. -1 core tests.
The test failure TestMapReduceLazyOutput.testLazyOutput is not related to the
patch. The test failed because of ZipExceptions (MAPREDUCE-1642).
The same test passed on my machine.
> TaskRunner.prepare() and close() can be removed
> -----------------------------------------------
>
> Key: MAPREDUCE-1662
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1662
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.22.0
> Reporter: Amareshwari Sriramadasu
> Fix For: 0.22.0
>
> Attachments: patch-1662.txt
>
>
> TaskRunner.prepare() and close() methods call only mapOutputFile.removeAll().
> The removeAll() call is a always a no-op in prepare(), because the directory
> is always empty during start up of the task. The removeAll() call in close()
> is useless, because it is followed by a attempt directory cleanup. Since the
> map output files are in attempt directory, the call to close() is useless.
> After MAPREDUCE-842, these calls are under TaskTracker space, passing the
> wrong conf. Now, the calls do not make sense at all.
> I think we can remove the methods.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
