[
https://issues.apache.org/jira/browse/MAPREDUCE-1594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854293#action_12854293
]
Hong Tang commented on MAPREDUCE-1594:
--------------------------------------
The latest patch ("1594-yhadoop-20-1xx-1-4.patch") still has a few minor
issues. I fixed them and attached a new patch (1594-yhadoop-20-1xx-1-5.patch).
I also attached a separated diff from 1594-yhadoop-20-1xx-1-4.patch
(1594-diff-4-5.patch, so that it is easier to see what I have changed):
- Replacing the pattern of "enum.name().equals()" to directly enum comparison
in various places.
- In GridmixJob, made job field final. Cleaned up the exception logic of
PrivilegedExceptionAction.run().
- Move the functionality of setting SeqId and original name in GridmixJob ctor,
eliminating the need of setSeqId and setJobId.
- Added another pullDescription method in GridmixJob that takes a JobContext
object. (to avoid expose the key "gridmix.job.seq").
- The way RINTERVAL is calculated is wrong - when duration is less than 20000,
it would lead to RINTERVAL==0. Per offline conversation with Chris, it seems
that having a fine granularity for RINTERVAL is pointless since progress is
only updated when TT sends heartbeat to JT. So I reverted the way how RINTERVAL
is calculated.
- Changed to use System.currentTimeMilis() in SleepJob instead of
System.nanoTime() since we are dealing with mili-sec granularity.
- In both TestGridmixSubmission and TestSleepJob, the statements for setting
the configuration seems to be useless.
- Some indentation issues in GenerateData.
- Removed unused imports in GridmixJob
- Removed the unused LoadJob ctor.
> Support for Sleep Jobs in gridmix
> ---------------------------------
>
> Key: MAPREDUCE-1594
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1594
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: contrib/gridmix
> Reporter: rahul k singh
> Attachments: 1376-5-yhadoop20-100-3.patch, 1594-diff-4-5.patch,
> 1594-yhadoop-20-1xx-1-2.patch, 1594-yhadoop-20-1xx-1-3.patch,
> 1594-yhadoop-20-1xx-1-4.patch, 1594-yhadoop-20-1xx-1-5.patch,
> 1594-yhadoop-20-1xx-1.patch, 1594-yhadoop-20-1xx.patch
>
>
> Support for Sleep jobs in gridmix
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
