[
https://issues.apache.org/jira/browse/MAPREDUCE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856798#action_12856798
]
Balaji Rajagopalan commented on MAPREDUCE-1693:
-----------------------------------------------
1. There is java docs missing from GenerateTaskChildProcess::map, same comment
applicable for other public method. If the method is utility method then make
it private.
2. createChildProcess please give more information in javadocs and how the
script is launching the child processes.
3. We use the helper ShellCommandExecutor for launching the scripts I see you
are not using it, please plan to use ShellCommandExecutor for launching shell
scripts instead of RunTime.
4. Give meaningful messages for assertNull in
testProcessTreeCleanupAfterJobKilled
> Process tree clean up of either a failed task or killed task tests.
> -------------------------------------------------------------------
>
> Key: MAPREDUCE-1693
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1693
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: test
> Reporter: Vinay Kumar Thota
> Assignee: Vinay Kumar Thota
> Attachments: taskchildskilling_1693.diff,
> taskchildskilling_1693.diff, taskchildskilling_1693.patch
>
>
> The following scenarios covered in the test.
> 1. Run a job which spawns subshells in the tasks. Kill one of the task. All
> the child process of the killed task must be killed.
> 2. Run a job which spawns subshells in tasks. Fail one of the task. All the
> child process of the killed task must be killed along with the task after its
> failure.
> 3. Check process tree cleanup on paritcular task-tracker when we use
> -kill-task and -fail-task with both map and reduce.
> 4. Submit a job which would spawn child processes and each of the child
> processes exceeds the memory limits. Let the job complete . Check if all the
> child processes are killed, the overall job should fail.
> l)Submit a job which would spawn child processes and each of the child
> processes exceeds the memory limits. Kill/fail the job while in progress.
> Check if all the child processes are killed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
