[
https://issues.apache.org/jira/browse/MAPREDUCE-1710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858394#action_12858394
]
Iyappan Srinivasan commented on MAPREDUCE-1710:
-----------------------------------------------
Code looks good. Some comments.
1) Check if all import statements make sense . - NetworkedJob is not required.
Check for all imports.
2) There should be space between parameters in methods like in this :
UtilsForSystemTests.restartCluster(cluster,prop); Check this for throughout
testcase.
3) resetClusterWithNewConfigMapred seems a better name than resetCluster,
becuse users can understand the intent of this feature just by reading the name
rather than seeing the javadocs. The same goes with resetCluster. It can be
resetClusterWithOldConfig.
4) All input, output directory creation and deletion should be done in
BeforeClass and AfterClass. This to avoid testcase assuming that a directory
is already present. and a testacse cleaning up all directories it created
before exiting, even if it failed inteh middle.
5) if (!tttInfo.isTaskCleanupTask()) - Even setup task could be checked to
avoid it and made fully sure its only mapper.
> Process tree clean up of exceeding memory limit tasks.
> ------------------------------------------------------
>
> Key: MAPREDUCE-1710
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1710
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: test
> Reporter: Vinay Kumar Thota
> Assignee: Vinay Kumar Thota
> Attachments: memorylimittask_1710.patch
>
>
> 1. Submit a job which would spawn child processes and each of the child
> processes exceeds the memory limits. Let the job complete . Check if all the
> child processes are killed, the overall job should fail.
> 2. Submit a job which would spawn child processes and each of the child
> processes exceeds the memory limits. Kill/fail the job while in progress.
> Check if all the child processes are killed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
