[
https://issues.apache.org/jira/browse/MAPREDUCE-1695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858992#action_12858992
]
Hemanth Yamijala commented on MAPREDUCE-1695:
---------------------------------------------
bq. Only reason I kept it there is in case these classes are constructed
through reflection and removing a parameter would lead to constructor-not-found
exception.
Hong, I don't think this is the case for the classes in question - namely
QueueInfo and TaskSchedulingContext. IMO, it would make the code more clear
removing them.
I agree leaving the other methods untouched, because they don't hurt or confuse
in any way, and as you point out might help in future.
+1 also for fixing MAPREDUCE-1715 separately.
> capacity scheduler is not included in findbugs/javadoc targets
> --------------------------------------------------------------
>
> Key: MAPREDUCE-1695
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1695
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/capacity-sched
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: MAPREDUCE-1695-2.patch, mapreduce-1695-20100420.patch,
> MAPREDUCE-1695-3.patch, MAPREDUCE-1695.patch,
> mr1695-hadoop-findbugs-report-1.html, mr1695-hadoop-findbugs-report-2.html
>
>
> Capacity Scheduler is not included in findbugs/javadoc targets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
