[
https://issues.apache.org/jira/browse/MAPREDUCE-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865860#action_12865860
]
Hong Tang commented on MAPREDUCE-1711:
--------------------------------------
I applied your patch to yhadoop 20.10 and compared it with 20.1xx. I will
attach the diff files after this.
Some comments:
- src/contrib/build.xml contains changes related to hdfsproxy.
- In the first GridmixJob constructor, you are setting the UGI in the shared
instance of Configuration object. This would interfere with jobs submitted
concurrently.
- In JobSubmitter.java, should keep the same logging messages.
- Please remove the GridmixSplit class
- EchoUserResolver is not synced with 20.1xx branch (see diff-gridmix.patch).
- TestGridmixSubmission, I saw some changes not synced (see diff-gridmix.patch).
- Some changes in Rumen do not seem to be synced (see diff-rumen.patch).
Also, a general comment, please try to minimize white space changes. Otherwise,
it would make future cross porting harder, and increase the burden of reviewing
effort.
> Gridmix should provide an option to submit jobs to the same queues as
> specified in the trace.
> ---------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1711
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1711
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: contrib/gridmix
> Reporter: Hong Tang
> Assignee: rahul k singh
> Attachments: diff-gridmix.patch, diff-rumen.patch,
> MR-1711-yhadoop-20-1xx-2.patch, MR-1711-yhadoop-20-1xx-3.patch,
> MR-1711-yhadoop-20-1xx-4.patch, MR-1711-yhadoop-20-1xx-5.patch,
> MR-1711-yhadoop-20-1xx-6.patch, MR-1711-yhadoop-20-1xx-7.patch,
> MR-1711-yhadoop-20-1xx.patch, MR-1711-Yhadoop-20-crossPort.patch,
> mr-1711-yhadoop-20.1xx-20100416.patch
>
>
> Gridmix should provide an option to submit jobs to the same queues as
> specified in the trace.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
