[
https://issues.apache.org/jira/browse/MAPREDUCE-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866440#action_12866440
]
Konstantin Boudnik commented on MAPREDUCE-1753:
-----------------------------------------------
I have a couple of concerns about this approach:
- once a DaemonProcess in question is suspended (i.e. its VM is effectively
suspended) will you be able to resume it via a method invocation in a class
running on that VM? I haven't verified it but something tells me that it won't
work.
If I am mistaken in that one then a few more:
- property name {{test.system.task.resume.cmd}} isn't consistent with the rest
of properties from {{system-test.xml}}. Also, the default has to be added to
{{system-test.xml}} and documented properly.
- instead of returning 0 and 1 (??) return boolean
- has to be {...@throws}} not {{@ throws}}
- same for {...@return}} not {{@ return}}
- as usual, missing descriptions of @throws
> Implement a functionality for suspend and resume the process.
> -------------------------------------------------------------
>
> Key: MAPREDUCE-1753
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1753
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: test
> Reporter: Vinay Kumar Thota
> Assignee: Vinay Kumar Thota
> Attachments: 1753-ydist-security.patch, daemonprotocolaspect.patch
>
>
> Adding two methods in DaemonProtocolAspect.aj for suspend and resume the
> process.
> public int DaemonProtocol.resumeProcess(String pid) throws IOException;
> public int DaemonProtocol.suspendProcess(String pid) throws IOException;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
