[
https://issues.apache.org/jira/browse/MAPREDUCE-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12881347#action_12881347
]
Todd Lipcon commented on MAPREDUCE-1887:
----------------------------------------
Couple notes:
- Rather than changing all the instances of "volumes" to "this.volumes" can you
rename one of the variables? like rename the constructor argument to
unnormalizedVolumes, and then you can just use "volumes" throughout? That
should reduce changes that someone changing this code later makes the mistake
again.
- Missing @Test annotation on testRelativeToWorking()
- Might be worth adding a comment to testVolumeNormalization stating it's a
regression test for this JIRA number.
- Either remove or change the log message "Volume: foo -> bar" - eg "Normalized
MRAsyncDiskService volume foo -> bar" or just get rid of it.
> MRAsyncDiskService does not properly absolutize volume root paths
> -----------------------------------------------------------------
>
> Key: MAPREDUCE-1887
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1887
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: MAPREDUCE-1887.patch
>
>
> In MRAsyncDiskService, volume names are sometimes specified as relative
> paths, which are not converted to absolute paths. This can cause errors of
> the form "cannot delete </full/path/to/foo> since it is outside of
> <relative/volume/root>" even though the actual path is inside the root.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
