[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882402#action_12882402
 ] 

Krishna Ramachandran commented on MAPREDUCE-1699:
-------------------------------------------------

In trunk I believe, all job state loggings  are handled in 
jobHistory.logEvent(jobId) {

  /**
   * Method to log the specified event
   * @param event The event to log
   * @param id The Job ID of the event
   */
  public void logEvent(HistoryEvent event, JobID id) {
    try {
      final MetaInfo mi = fileMap.get(id);
      if (mi != null) {
        mi.writeEvent(event);
      }
    } catch (IOException e) {
      LOG.error("Error Logging event, " + e.getMessage());
    }
  }
}

if logging fails just log a message. This is a lot cleaner - disableHistory is 
never used



> JobHistory shouldn't be disabled for any reason
> -----------------------------------------------
>
>                 Key: MAPREDUCE-1699
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1699
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobtracker
>    Affects Versions: 0.20.2
>            Reporter: Arun C Murthy
>            Assignee: Krishna Ramachandran
>             Fix For: 0.20.3
>
>         Attachments: mapred-1699-1.patch, mapred-1699-2.patch, 
> mapred-1699-3.patch, mapred-1699.patch
>
>
> Recently we have had issues with JobTracker silently disabling job-history 
> and starting to keep all completed jobs in memory. This leads to OOM on the 
> JobTracker. We should never do this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to