[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883066#action_12883066
 ] 

Iyappan Srinivasan commented on MAPREDUCE-1871:
-----------------------------------------------

In StatisticsCollectorAspect provide the comments in java docs format. 

- [Iyappan] Done

testTaskTrackerInfoAll there is loop which does the same job submission and
verification 3 times, should the submission and verification be in parallel or
sequential ? Please provide information on docs why we submit the job 3 times. 

- [Iyappan] Actually 3 times sequential is not necesary, since the further 
testacses anyway runs more jobs.So removed it.

testTaskTrackerInfoKilled the total number of succeeded jobs should be less, 
since
we explicitly kill a task, so can you please provide some comments in the code, 
how
your calculation is different from the successful scenario. The same thing 
holds good
for testTaskTrackerInfoTaskFailure. 

- [Iyappan]  Comments provided.

FailedMapperClass already exist in testjar, this can be reused. We have this 
practice to put
the mapper and reducer class used in herriot in testjar, so it can be used from 
there. 

- [Iyappan] Done

getTaskTrackerLevelStatistics I don't see a need to pass the TaskTrackerStatus 
object,
we are obtaining this from server side, and passing it again to server side. 
The JobTracker
should have all the task tracker names right, why not get all the information 
in single shot so you will have to change the interface to array of data, which 
I think
is right way to do this. 

- [Iyappan] Done

getTTClientIns should be moved to TTClient, since it is good to have it there. 
Other could also make use of this, please add it if TTClient does not any such 
method. The same comment is applicable for waitForTTStart and waitForTTStop.

- [Iyappan] Done

Please add cos and vinay as watchers to this jira. 

- [Iyappan] Done

 


> Create automated test scenario for "Collect information about number of tasks 
> succeeded / total per time unit for a tasktracker"
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1871
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1871
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>            Reporter: Iyappan Srinivasan
>            Assignee: Iyappan Srinivasan
>         Attachments: 1871-ydist-security-patch.txt, 
> 1871-ydist-security-patch.txt
>
>
> Create automated test scenario for "Collect information about number of tasks 
> succeeded / total per time unit for a tasktracker"
> 1) Verification of all the above mentioned fields with the specified TTs. 
> Total no. of tasks and successful tasks should be equal to the corresponding 
> no. of tasks specified in TTs logs
> 2)  Fail a task on tasktracker.  Node UI should update the status of tasks on 
> that TT accordingly. 
> 3)  Kill a task on tasktracker.  Node UI should update the status of tasks on 
> that TT accordingly
> 4) Positive Run simultaneous jobs and check if all the fields are populated 
> with proper values of tasks.  Node UI should have correct valiues for all the 
> fields mentioned above. 
> 5)  Check the fields across one hour window  Fields related to hour should be 
> updated after every hour
> 6) Check the fields across one day window  fields related to hour should be 
> updated after every day
> 7) Restart a TT and bring it back.  UI should retain the fields values.  
> 8) Positive Run a bunch of jobs with 0 maps and 0 reduces simultanously.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to