[
https://issues.apache.org/jira/browse/MAPREDUCE-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887646#action_12887646
]
Ravi Gummadi commented on MAPREDUCE-1865:
-----------------------------------------
Some minor comments on the patch:
(1) The follwoing line in the test case testJobHistoryFilenameParsing() seems
to be unused code(so can be removed).
Path inDir = new Path(rootInputDir, "test");
(2) Javadoc for the testcase testJobHistoryFilenameParsing() can be changed to
something like history_file_name_parsing/JH_conf_file_name_parsing instead of
just saying parsing apis sothat it will be clear that it is validating parsing
of file names and not parsing content of files. Also assertion-failure messages
should say 'parsing of file names' instead of 'parsing of files'.
(3) testCurrentJHParser() seems to be assuming that the SETUP & CLEANUP tasks
will be launched using map slots only. To avoid this assumption, should we set
"mapreduce.job.committer.setup.cleanup.needed" to false for this job ?
(4) Please add "lfs.delete(tempDir, true);" in the finally block in
testCurrentJHParser() to clean input and output directories.
(5) 2 comments in Pre21JobHistoryConstants.java have missplelt word
'jt-indentifier'.
--------------------------
Other code changes look good.
> [Rumen] Rumen should also support jobhistory files generated using trunk
> ------------------------------------------------------------------------
>
> Key: MAPREDUCE-1865
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1865
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tools/rumen
> Affects Versions: 0.22.0
> Reporter: Amar Kamat
> Assignee: Amar Kamat
> Fix For: 0.22.0
>
> Attachments: mapreduce-1865-v1.2.patch, mapreduce-1865-v1.6.2.patch
>
>
> Rumen code in trunk parses and process only jobhistory files from pre-21
> hadoop mapreduce clusters. It should also support jobhistory files generated
> using trunk.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
