[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888472#action_12888472
 ] 

Konstantin Boudnik commented on MAPREDUCE-1919:
-----------------------------------------------

I want to disagree with the suggestion on moving this little method to a helper 
class. It doesn't make much sense to create a wrapper around a well know 
ToolRunner interface - it just creates confusion. Why don't you simply use 
{{int exitCode = ToolRunner.run(job, tool, jobArgs)}} ? Why do you need a 
method to wrap a call to another one?

Also, please consider the optimization for the imports list - it is over 
detailed. 

> [Herriot] Test for verification of per cache file ref  count.
> -------------------------------------------------------------
>
>                 Key: MAPREDUCE-1919
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1919
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: test
>            Reporter: Vinay Kumar Thota
>            Assignee: Vinay Kumar Thota
>         Attachments: 1919-ydist-security.patch, MAPREDUCE-1919.patch
>
>
> It covers the following scenarios.
> 1. Run the job with two distributed cache files and verify whether job is 
> succeeded or not.
> 2.  Run the job with distributed cache files and remove one cache file from 
> the DFS when it is localized.verify whether the job is failed or not.
> 3.  Run the job with two distribute cache files and the size of  one file 
> should be larger than local.cache.size.Verify  whether job is succeeded or 
> not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to