[
https://issues.apache.org/jira/browse/MAPREDUCE-2000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897094#action_12897094
]
Hong Tang commented on MAPREDUCE-2000:
--------------------------------------
bq. 1. There's redundant "return" statement introduced by your patch.
Will do.
bq. 2. I would personally prefer a new-line before the "/**" lines to improve
readability a bit.
This is probably a matter of different style. I prefer to use blank lines to
separate logically different groups.
bq. 3. Do you think it makes sense to include the actual input-line above that
triggered the bug in the unit test-case?
We should verify the patch to make sure it fixes the real bug. But I think that
unit tests should test minimally what it is supposed to test. In other words, I
think including actual input that causes the bug is a bad idea. It would simply
obscure what the unit test is supposed to cover.
> Rumen is not able to extract counters for Job history logs from Hadoop 0.20
> ---------------------------------------------------------------------------
>
> Key: MAPREDUCE-2000
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2000
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tools/rumen
> Reporter: Hong Tang
> Assignee: Hong Tang
> Attachments: mr-2000-20100806.patch, mr-2000-20100809.patch,
> mr-2000-20100810.patch
>
>
> Rumen tries to match the end of a value string through indexOf("\""). It does
> not take into account the case when an escaped '"' in the value string. This
> leads to the incorrect parsing the remaining key=value properties in the same
> line.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
