[
https://issues.apache.org/jira/browse/MAPREDUCE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897159#action_12897159
]
Vinod K V commented on MAPREDUCE-1780:
--------------------------------------
Some comments:
- JobSubmittedEvent is used to persist job-acls to JobHistory but the acls are
incorrectly written through toString() method. Please add a test/modify the
existing test in TestJobHistory to verify this bug.
- Minor: Not directly related to the patch, but can fix it here. In
QueueManger.dumpConfiguration(), we don't need aclsSubmitJobValue to be a
StringBuilder. We can drop off getAclsInfo() method itself.
> AccessControlList.toString() is used for serialization of ACL in
> JobStatus.java
> -------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1780
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1780
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: 1780.patch
>
>
> HADOOP-6715 is created to fix AccessControlList.toString() for the case of
> WILDCARD. JobStatus.write() and readFields() assume that toString() returns
> the serialized String of AccessControlList object, which is not true. Once
> HADOOP-6715 gets fixed in COMMON, JobStatus.write() and
> JobStatus.readFields() should be fixed depending on the fix of HADOOP-6715.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
