[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904476#action_12904476
 ] 

Luke Lu commented on MAPREDUCE-2043:
------------------------------------

@Chris, see MAPREDUCE-1881 for a summary comparison between the instrumentation 
interface and the metrics framework.

The intended audience for the instrumentation classes is NOT administrators but 
experimental framework developers that either embed or extend Hadoop.

-1 for making the interface public in the sense that it's our (Hadoop 
community) obligation to maintain/document the interface. I'd strongly advocate 
that we reserve the right to change instrumentation interface without the usual 
constraints of public APIs. 

+0 if proper interface classification annotations are used i.e.:

@InterfaceAudience.Private
@InterfaceStability.Evolving



> TaskTrackerInstrumentation and JobTrackerInstrumentation should be public
> -------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2043
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2043
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: tasktracker
>    Affects Versions: 0.22.0
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>         Attachments: MAPREDUCE-2043.patch.txt
>
>
> Hadoop administrators can specify classes to be loaded as 
> "TaskTrackerInstrumentation" and "JobTrackerInstrumentation" implementations, 
> which, roughly, define listeners on TT and JT events.  Unfortunately, since 
> the class has default access, extending it requires setting the extension's 
> package to org.apache.hadoop.mapred, which seems like poor form.
> I propose we make the two instrumentation classes public, so they can be 
> extended wherever.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to