[
https://issues.apache.org/jira/browse/MAPREDUCE-1548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907773#action_12907773
]
Mahadev konar commented on MAPREDUCE-1548:
------------------------------------------
+1, the patch looks good.
Rodrigo,
Just a minor nit:
- can you add some comments that propsplits is a different column if the entry
in index is a directory or a file? Its a little confusing when you see the
code. Just add a comment in HarFilesystem that propsplits is stored in
different columns depending on a dir or a file.
Other than that patch looks good. I will go ahead and commit as soon as you
make the change.
thanks
> Hadoop archives should be able to preserve times and other properties from
> original files
> -----------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-1548
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1548
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: harchive
> Affects Versions: 0.22.0
> Reporter: Rodrigo Schmidt
> Assignee: Rodrigo Schmidt
> Fix For: 0.22.0
>
> Attachments: MAPREDUCE-1548.0.patch, MAPREDUCE-1548.1.patch,
> MAPREDUCE-1548.2.patch, MAPREDUCE-1548.3.patch
>
>
> Files inside hadoop archives don't keep their original:
> - modification time
> - access time
> - permission
> - owner
> - group
> all such properties are currently taken from the file storing the archive
> index, and not the stored files. This doesn't look very correct.
> There should be possible to preserve the original properties of the stored
> files.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
