[
https://issues.apache.org/jira/browse/MAPREDUCE-2081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917516#action_12917516
]
Ranjit Mathew commented on MAPREDUCE-2081:
------------------------------------------
* Use HashMap instead of Hashtable in the return types - better yet, use just
Map (ditto for ArrayList -> List).
* "It gives" -> "Gives" in the first sentence of the JavaDoc comments for the
new methods.
* You will need to change, for example, "<numeric>" to
"&lt;numeric&gt;" in the JavaDoc comments for it to be rendered
correctly in the generated HTML documentation.
* Do not say ??There is no restriction on file and user can use their own
names??, since you *do* have a restriction.
* In {{getMRTraces()}}, do you think it makes sense to validate that the text
between "_" and "{d,h,m}.json.gz" is actually a number?
* I think the {{listMRTraces()}} methods are not needed as they can be subsumed
by a call to {{Map.values()}} on the returned {{Map}} from the
{{getMRTraces()}} methods.
* Is the consumer of these methods supposed to know the desired time-period up
front? (As in ??Give me all traces that run for 10 minutes??.)
> [GridMix3] Implement functionality for get the list of job traces which has
> different intervals.
> ------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2081
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2081
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: contrib/gridmix
> Reporter: Vinay Kumar Thota
> Assignee: Vinay Kumar Thota
> Attachments: 2081-ydist.patch
>
>
> Girdmix system tests should require different job traces with different time
> intervals for generate and submit the gridmix jobs. So, implement a
> functionaliy for getting the job traces and arrange them in hash table with
> time interval as key.Also getting the list of traces from resource location
> irrespective of time. The following methods needs to implement.
> Method signature:
> public static Hashtable <String, String> getMRTraces(Configuration conf)
> throws IOException; - it get the traces with time intervals from resources
> default location.
> public static Hashtable <String, String> getMRTraces(Configuration conf,Path
> path) throws IOException; - it get the traces with time intervals from user
> specified resource location.
> public static ArrayList<String> listMRTraces(Configuration conf) throws
> IOException -it list all the traces from resource default location
> irrespective of time interval.
> public static ArrayList<String> listMRTraces(Configuration conf, Path
> tracesPath) throws IOException - it list all the traces from user specified
> user location irrespective of time interval.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
