[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12918852#action_12918852
 ] 

Ravi Gummadi commented on MAPREDUCE-2095:
-----------------------------------------

Code changes look fine to me.

Some minor comments on the testcase:
(1) io.close() can be moved to finally block.
(2) Also, please delete the contents of rootTempDir in the finally block.
(3) Please add some javadoc to the testcase.
(4) Please include the data file wordcount.json.gz in the patch so that 
committer need not have to remember the path where it is to be committed.

> Gridmix unable to run for compressed traces(.gz format).
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-2095
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2095
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: contrib/gridmix
>    Affects Versions: 0.20.1
>            Reporter: Vinay Kumar Thota
>            Assignee: Ranjit Mathew
>         Attachments: MAPREDUCE-2095.patch, MAPREDUCE-2095_v2.patch, 
> wordcount.json.gz
>
>
> I was trying to run gridmix with compressed trace file.However, it throws a 
> JsonParseException and exit.
> exception details:
> ==================
> org.codehaus.jackson.JsonParseException: Illegal character ((CTRL-CHAR, code 
> 31)): only regular white space (\r, \n,
> \t) is allowed between tokens
>  at [Source: org.apache.hadoop.fs.fsdatainputstr...@17ba38f; line: 1, column: 
> 2]
>         at 
> org.codehaus.jackson.impl.JsonParserBase._constructError(JsonParserBase.java:651)
>         at 
> org.codehaus.jackson.impl.JsonParserBase._reportError(JsonParserBase.java:635)
>         at 
> org.codehaus.jackson.impl.JsonParserBase._throwInvalidSpace(JsonParserBase.java:596)
>         at 
> org.codehaus.jackson.impl.Utf8StreamParser._skipWSOrEnd(Utf8StreamParser.java:981)
>         at 
> org.codehaus.jackson.impl.Utf8StreamParser.nextToken(Utf8StreamParser.java:77)
>         at 
> org.codehaus.jackson.map.ObjectMapper._initForReading(ObjectMapper.java:688)
>         at 
> org.codehaus.jackson.map.ObjectMapper._readValue(ObjectMapper.java:624)
>         at 
> org.codehaus.jackson.map.ObjectMapper.readValue(ObjectMapper.java:275)
>         at 
> org.apache.hadoop.tools.rumen.JsonObjectMapperParser.getNext(JsonObjectMapperParser.java:84)
>         at 
> org.apache.hadoop.tools.rumen.ZombieJobProducer.getNextJob(ZombieJobProducer.java:117)
>         at 
> org.apache.hadoop.tools.rumen.ZombieJobProducer.getNextJob(ZombieJobProducer.java:29)
>         at 
> org.apache.hadoop.mapred.gridmix.JobFactory.getNextJobFiltered(JobFactory.java:174)
>         at 
> org.apache.hadoop.mapred.gridmix.StressJobFactory$StressReaderThread.run(StressJobFactory.java:166)
> 10/09/23 09:43:17 ERROR gridmix.Gridmix: Error in trace
> org.codehaus.jackson.JsonParseException: Illegal character ((CTRL-CHAR, code 
> 31)): only regular white space (\r, \n,
> \t) is allowed between tokens
>  at [Source: org.apache.hadoop.fs.fsdatainputstr...@17ba38f; line: 1, column: 
> 2]
>         at 
> org.codehaus.jackson.impl.JsonParserBase._constructError(JsonParserBase.java:651)
>         at 
> org.codehaus.jackson.impl.JsonParserBase._reportError(JsonParserBase.java:635)
>         at 
> org.codehaus.jackson.impl.JsonParserBase._throwInvalidSpace(JsonParserBase.java:596)
>         at 
> org.codehaus.jackson.impl.Utf8StreamParser._skipWSOrEnd(Utf8StreamParser.java:981)
>         at 
> org.codehaus.jackson.impl.Utf8StreamParser.nextToken(Utf8StreamParser.java:77)
>         at 
> org.codehaus.jackson.map.ObjectMapper._initForReading(ObjectMapper.java:688)
>         at 
> org.codehaus.jackson.map.ObjectMapper._readValue(ObjectMapper.java:624)
>         at 
> org.codehaus.jackson.map.ObjectMapper.readValue(ObjectMapper.java:275)
>         at 
> org.apache.hadoop.tools.rumen.JsonObjectMapperParser.getNext(JsonObjectMapperParser.java:84)
>         at 
> org.apache.hadoop.tools.rumen.ZombieJobProducer.getNextJob(ZombieJobProducer.java:117)
>         at 
> org.apache.hadoop.tools.rumen.ZombieJobProducer.getNextJob(ZombieJobProducer.java:29)
>         at 
> org.apache.hadoop.mapred.gridmix.JobFactory.getNextJobFiltered(JobFactory.java:174)
>         at 
> org.apache.hadoop.mapred.gridmix.StressJobFactory$StressReaderThread.run(StressJobFactory.java:166)
> 10/09/23 09:43:17 INFO gridmix.Gridmix: Exiting...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to