[
https://issues.apache.org/jira/browse/MAPREDUCE-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joydeep Sen Sarma updated MAPREDUCE-2116:
-----------------------------------------
Attachment: 2116.3.patch
revised patch addressing findBugs warnings. here's the hadoopQA output:
[exec] BUILD SUCCESSFUL
[exec] Total time: 1 minute 25 seconds
[exec]
[exec]
[exec]
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new
or modified tests.
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system tests framework. The patch passed system tests
framework compile.
[exec]
[exec]
[exec]
[exec]
[exec]
======================================================================
[exec]
======================================================================
[exec] Finished build.
[exec]
======================================================================
[exec]
======================================================================
[exec]
> optimize getTasksToKill to reduce JobTracker contention
> -------------------------------------------------------
>
> Key: MAPREDUCE-2116
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2116
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: jobtracker
> Reporter: Joydeep Sen Sarma
> Attachments: 2116.1.patch, 2116.2.patch, 2116.3.patch,
> getTaskToKill.JPG
>
>
> getTasksToKill shows up as one of the top routines holding the JT lock.
> Specifically, the translation from attemptid to tip is very expensive:
> at java.util.TreeMap.getEntry(TreeMap.java:328)
> at java.util.TreeMap.get(TreeMap.java:255)
> at
> org.apache.hadoop.mapred.TaskInProgress.shouldClose(TaskInProgress.java:500)
> at
> org.apache.hadoop.mapred.JobTracker.getTasksToKill(JobTracker.java:3464)
> locked <0x00002aab6ebb6640> (a org.apache.hadoop.mapred.JobTracker)
> at org.apache.hadoop.mapred.JobTracker.heartbeat(JobTracker.java:3181)
> this seems like an avoidable expense since the tip for a given attempt is
> fixed (and one should not need a map lookup to find the association). on a
> different note - not clear to me why TreeMaps are in use here (i didn't find
> any iteration over these maps). any background info on why things are
> arranged the way they are would be useful.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
