[jira] Commented: (MAPREDUCE-2169) Integrated Reed-Solomon code with RaidNode

[Scott Chen (JIRA)]

    [ 
https://issues.apache.org/jira/browse/MAPREDUCE-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929921#action_12929921
 ] 

Scott Chen commented on MAPREDUCE-2169:
---------------------------------------

Thanks Ram. I have some comments.

{code}
+  public static String xorTempPrefix(Configuration conf) {
{code}
Can you rename it to unraidTmpDirectory()

{code}
-    // generate parity file
-    generateParityFile(conf, stat, reporter, srcFs, destPath, locations, 
metaRepl, stripeLength);
-
     // reduce the replication factor of the source file
     if (!doSimulate) {
       if (srcFs.setReplication(p, (short)targetRepl) == false) {
{code}
generateParityFile should be done before setReplication

{code}
+          if (code == ErasureCodeType.XOR) {
+            ParityFilePair ppair = getParityFile(
+               getDestinationPath(ErasureCodeType.RS, conf), srcPath, conf);
+            if (ppair != null) {
+              shouldDelete = true;
+            }
+          }
+          if (!shouldDelete) {
+            Path dstPath = (new Path(destPrefix.trim())).makeQualified(destFs);
+            ParityFilePair ppair = getParityFile(dstPath,srcPath);
+            if ( ppair == null ||
+                 !destFs.equals(ppair.getFileSystem()) ||
+                 !destPath.equals(ppair.getPath())) {
+              shouldDelete = true;
+            }
+          }
{code}
Can you add some comments explaining the purge policy?

{code}
-  public void testReadFully() throws Exception {
-  public void testAccessTime() throws Exception {
{code}
Can you put back these tests? I think you delete them accidentally.


> Integrated Reed-Solomon code with RaidNode
> ------------------------------------------
>
>                 Key: MAPREDUCE-2169
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2169
>             Project: Hadoop Map/Reduce
>          Issue Type: Task
>          Components: contrib/raid
>            Reporter: Ramkumar Vadali
>            Assignee: Ramkumar Vadali
>         Attachments: MAPREDUCE-2169.patch
>
>
> Scott Chen recently checked in an implementation of  the Reed Solomon code. 
> This task will track the integration of the code with RaidNode.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.