[ https://issues.apache.org/jira/browse/MAPREDUCE-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059263#comment-13059263 ]
Arun C Murthy commented on MAPREDUCE-2633: ------------------------------------------ The patch looks fine, thanks Josh! Sharad could you please take a quick look too? One thing - there was some talk of deprecating Counters.getCounter(Enum) in favour of Counters.getCounter(String). I need to refresh my memory, in which case we might deprecate the one added by Josh right-away. Thoughts? > MR-279: Add a getCounter(Enum) method to the Counters interface > --------------------------------------------------------------- > > Key: MAPREDUCE-2633 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2633 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: mrv2 > Environment: All > Reporter: Josh Wills > Assignee: Josh Wills > Priority: Minor > Attachments: MAPREDUCE-2633.patch > > > I'm fixing a few TODOs I came across in TaskAttemptImpl.java related to the > fact that the MRv2 Counters interface don't expose a getCounter(Enum) method > for accessing a Counter using the enum's class as the group name and the > enum's value as the name of the counter. > Will add the patch momentarily. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira