[
https://issues.apache.org/jira/browse/MAPREDUCE-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059291#comment-13059291
]
Josh Wills commented on MAPREDUCE-2630:
---------------------------------------
No worries Arun- it was a hectic week. Really enjoyed your talk at the Summit,
lots of good questions from the audience.
My preference for the two separate methods was based on the idea that the
containerTokenSecretManager and clusterTracker really should never change once
the scheduler is init'd, and that having the two separate methods would prevent
any other scheduler impls that came along from introducing the same kind of
error. If that isn't true, i.e., there is some situation where we would want to
change the value of the containerTokenSecretManager/clusterTracker, I'm fine to
have the single reinit method.
> MR-279: refreshQueues leads to NPEs when used w/FifoScheduler
> -------------------------------------------------------------
>
> Key: MAPREDUCE-2630
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2630
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Environment: All
> Reporter: Josh Wills
> Assignee: Josh Wills
> Priority: Minor
> Attachments: MAPREDUCE-2630.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The RM's admin service exposes a method refreshQueues that is used to update
> the queue configuration when used with the CapacityScheduler, but if it is
> used with the FifoScheduler, it will set the
> containerTokenSecretManager/clusterTracker fields on the FifoScheduler to
> null, which eventually leads to NPE. Since the FifoScheduler only has one
> queue that cannot be refreshed, the correct behavior is for the refreshQueues
> call to be a no-op.
> I will attach a patch that fixes this by splitting the ResourceScheduler's
> reinitialize method into separate initialize/updateQueues methods.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
