[
https://issues.apache.org/jira/browse/MAPREDUCE-2639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059644#comment-13059644
]
Aaron T. Myers commented on MAPREDUCE-2639:
-------------------------------------------
Hey Josh, I'd recommend breaking this out into separate JIRAs as subtasks of
this one, so that those who want to give feedback can localize the
review/discussion to smaller areas.
> MR-279: Fixup the exponentially smoothed runtime estimator, fix a couple of
> bugs in DataStatistics, and do a little bit of cleanup.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2639
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2639
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv2
> Environment: All
> Reporter: Josh Wills
> Assignee: Josh Wills
> Priority: Minor
> Attachments: MAPREDUCE-2639-1.patch, MAPREDUCE-2639-2.patch,
> MAPREDUCE-2639-3.patch
>
>
> A catch-all JIRA for a pass I took through the v2.app.speculate package.
> 1) Fixed the ExponentiallySmoothedTaskRuntimeEstimator so that it can run and
> pass the test defined in TestRuntimeEstimators.
> 2) Fixed two bugs in DataStatistics: 1) a divide by zero in the variance
> calculation in the case that count == 0 and 2) a synchronization issue in how
> the updateStatistics method was implemented,
> 3) A bunch of typo corrections, formatting fixes, and adding some consistency
> around the null value checking.
> I probably need to do a couple more passes through this code to get it into
> better shape, but this seemed like a good start. Will attach my patch
> momentarily.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
