[ https://issues.apache.org/jira/browse/MAPREDUCE-2243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072188#comment-13072188 ]
Devaraj K commented on MAPREDUCE-2243: -------------------------------------- Yes Nicholas, Good catch. I missed it. I will update the patch with single try, that will handle the above cases also. > Close all the file streams propely in a finally block to avoid their leakage. > ----------------------------------------------------------------------------- > > Key: MAPREDUCE-2243 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2243 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: jobtracker, tasktracker > Affects Versions: 0.22.0, 0.23.0 > Environment: NA > Reporter: Bhallamudi Venkata Siva Kamesh > Assignee: Devaraj K > Priority: Minor > Fix For: 0.23.0 > > Attachments: MAPREDUCE-2243-1.patch, MAPREDUCE-2243-2.patch, > MAPREDUCE-2243.patch > > Original Estimate: 72h > Remaining Estimate: 72h > > In the following classes streams should be closed in finally block to avoid > their leakage in the exceptional cases. > CompletedJobStatusStore.java > ------------------------------------------ > dataOut.writeInt(events.length); > for (TaskCompletionEvent event : events) { > event.write(dataOut); > } > dataOut.close() ; > EventWriter.java > ---------------------- > encoder.flush(); > out.close(); > MapTask.java > ------------------- > splitMetaInfo.write(out); > out.close(); > TaskLog > ------------ > 1) str = fis.readLine(); > fis.close(); > 2) dos.writeBytes(Long.toString(new File(logLocation, LogName.SYSLOG > .toString()).length() - prevLogLength) + "\n"); > dos.close(); > TotalOrderPartitioner.java > ----------------------------------- > while (reader.next(key, value)) { > parts.add(key); > key = ReflectionUtils.newInstance(keyClass, conf); > } > reader.close(); -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira