[
https://issues.apache.org/jira/browse/MAPREDUCE-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13084362#comment-13084362
]
Konstantin Shvachko commented on MAPREDUCE-2669:
------------------------------------------------
Good examples! Some comments:
# You need to address findbugs and javac warning if they are related to the
patch.
# Test failures do not seem to be relates to the new examples.
# I recommend using forward slashes in INPUT and OUTPUT constants
{code}
+ private final static String INPUT =
"src/test/mapred/org/apache/hadoop/examples/input";
+ private final static String OUTPUT =
"src/test/mapred/org/apache/hadoop/examples/robust_stddev_output";
{code}
# For INPUT directory I'd propose to use just {{INPUT =
"src/test/mapred/org/apache/hadoop/examples/}}.
As much as I love Shakespeare, committing "A Midsummer Night's Dream" under
Apache License doesn't seem to be required to exemplify MR statistics.
Having said that, it was interesting to learn that Shakespeare used pretty
short words - around 4.42 on average - compared to modern texts from the Web.
# OUTPUT directory should point to a directory in {{build/data}}, so that it is
cleaned up with the clean target.
# The tests should be converted to JUnit 4 format.
# Also it is better to combine all three test under common roof
{{TestWordStats}} or similar. It will be less code and will save test execution
time.
> Some new examples and test cases for them.
> ------------------------------------------
>
> Key: MAPREDUCE-2669
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2669
> Project: Hadoop Map/Reduce
> Issue Type: Test
> Components: examples
> Affects Versions: 0.22.0
> Reporter: Plamen Jeliazkov
> Priority: Minor
> Attachments: MAPREDUCE-2669.patch, MAPREDUCE-2669.patch,
> MAPREDUCE-2669.patch, MAPREDUCE-2669.patch, MAPREDUCE-2669.patch,
> MAPREDUCE-2669.patch, MAPREDUCE-2669.patch, mapreduce-new-examples-0.22.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Looking to add some more examples such as Mean, Median, and Standard
> Deviation to the examples.
> I have some generic JUnit testcases as well.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
