[
https://issues.apache.org/jira/browse/MAPREDUCE-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093659#comment-13093659
]
Sharad Agarwal commented on MAPREDUCE-2876:
-------------------------------------------
Sorry missed it earlier and saw it now.
bq. I would propose that we modify LivnessMonitor to store expiry in a priority
queue instead of a map. Then it can sleep just the amount of time needed before
the next one expires. It is fairly simple and I have done this type of thing in
the past. Then there is very little error from the expire interval, and we
don't have to worry about a monitor interval at all.
priority queue - This was exactly the same thing I was thinking the first time
when I wrote. The reason I chose Map is as follows - We receive pings from
AM/NM/Tasks etc very frequently in the order of 1-3 seconds. The no of
insertions in the priority queue would be huge. The *cumulative* cost of
multiple insertions in priority queue would be more than iterating over the
whole list every few seconds. make sense ?
> ContainerAllocationExpirer appears to use the incorrect configs
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-2876
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2876
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.0
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Fix For: 0.23.0
>
>
> ContainerAllocationExpirer sets the expiration interval to be
> RMConfig.CONTAINER_LIVELINESS_MONITORING_INTERVAL but uses
> AMLIVELINESS_MONITORING_INTERVAL as the interval. This is very different
> from what AMLivelinessMonitor does.
> There should be two configs RMConfig.CONTAINER_LIVELINESS_MONITORING_INTERVAL
> for the monitoring interval and RMConfig.CONTAINER_EXPIRY_INTERVAL for the
> expiry.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
