[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096004#comment-13096004
 ] 

Vinod Kumar Vavilapalli commented on MAPREDUCE-2745:
----------------------------------------------------

Looked at the patch.

While I understand the intention, I think Immutable-records are going to be a 
maintenance nightmare.

We can instead simply return clones to the webUI - a copy of the maps should be 
enough. If you are willing to go the full distance, you could supply the clones 
for all those objects which you wrote Immutable versions for - ApplicationId, 
Container, Application, LocalResource etc. You can see 
{{BuilderUtils.clone(Container c)}} for example.

> [MR-279] NM UI should get a read-only view instead of the actual NMContext 
> ---------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2745
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2745
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Anupam Seth
>              Labels: newbie
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2745-branch-0_23.patch
>
>
> NMContext is modifiable, the UI should only get read-only access. Just like 
> the AM web-ui.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to