[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096666#comment-13096666
 ] 

Hadoop QA commented on MAPREDUCE-2293:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12492900/mapreduce.mo.removecheck.r3.diff
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 findbugs.  The patch appears to introduce 8 new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-mapreduce-project.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/598//console

This message is automatically generated.

> Enhance MultipleOutputs to allow additional characters in the named output 
> name
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2293
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2293
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: David Rosenstrauch
>            Assignee: Harsh J
>            Priority: Minor
>             Fix For: 0.23.0
>
>         Attachments: mapreduce.mo.removecheck.r1.diff, 
> mapreduce.mo.removecheck.r2.diff, mapreduce.mo.removecheck.r3.diff
>
>
> Currently you are only allowed to use alpha-numeric characters in a named 
> output name in the MultipleOutputs class.  This is a bit of an onerous 
> restriction, as it would be extremely convenient to be able to use non 
> alpha-numerics in the name too.  (E.g., a '.' character would be very 
> helpful, so that you can use the named output name for holding a file 
> name/extension.  Perhaps '-' and a '_' characters as well.)
> The restriction seems to be somewhat arbitrary - it appears to be only 
> enforced in the checkTokenName method.  (Though I don't know if there's any 
> downstream impact by loosening this restriction.)
> Would be extremely helpful/useful to have this fixed though!

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to