[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated MAPREDUCE-2749:
-----------------------------------------------

    Status: Open  (was: Patch Available)

The patch looks good overall. But it needs a minor update because of 
MAPREDUCE-2864, TestNMRegistration has a minor compilation issue - 
YarnRPC.RPC_CLASSNAME has moved.

Also, I am suspecting that TestNMRegistration can be simplified a lot with mock 
objects. Changes to MiniYARNCluster also look hacky, to pass in the sleep 
interval. Please investigate if we can leverage mock objects, I'll do too. If 
we don't make progress in a day or two, I'll push the current code itself. 
Thanks!

> [MR-279] NM registers with RM even before it starts various servers
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2749
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2749
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Thomas Graves
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2749-v2.patch, MAPREDUCE-2749-v3.patch, 
> MAPREDUCE-2749-v4.patch, MAPREDUCE-2749.patch
>
>
> In case NM eventually fails to start the ContainerManager server because of 
> say a port clash, RM will have to wait for expiry to detect the NM crash.
> It is desirable to make NM register with RM only after it can start all of 
> its components successfully.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to