[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123097#comment-13123097
 ] 

Anupam Seth commented on MAPREDUCE-2876:
----------------------------------------

There is a test TestNmLivelinessMonitor that seems to do a fairly thorough job 
of testing expiry. NMLivenessMonitor is a subclass from AbstractLivenessMonitor 
and AMLivenessMonitor and ContainerAllocatorExpirer do almost the same thing. 
Please let me know if you would like me to add tests for AMLivenessMonitor and 
ContainerAllocatorExpirer or enhance coverage of this existing test in some way.
                
> ContainerAllocationExpirer appears to use the incorrect configs
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-2876
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2876
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Anupam Seth
>            Priority: Critical
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2876-branch-0_23.patch
>
>
> ContainerAllocationExpirer sets the expiration interval to be 
> RMConfig.CONTAINER_LIVELINESS_MONITORING_INTERVAL but uses 
> AMLIVELINESS_MONITORING_INTERVAL as the interval.  This is very different 
> from what AMLivelinessMonitor does.
> There should be two configs RMConfig.CONTAINER_LIVELINESS_MONITORING_INTERVAL 
> for the monitoring interval and RMConfig.CONTAINER_EXPIRY_INTERVAL for the 
> expiry.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to