[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated MAPREDUCE-2668:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Patch mostly looks good. Some nit-picking:
 - ApplicationImpl.handleAppFinishWithContainersCleanedup() doesn't need the 
ApplicationID argument.
 - AuxService.handle(): No need for the explicit check for 
Service.STATE.STARTED. We expect the service to handle it similar to initApp().
 - TestAuxServices
    -- Please remove unused imports.
    -- Rename all_appIds to stoppedApps ?
    -- The messages for the assert should be the negations of what you already 
have.

Thanks.
                
> MR-279: APPLICATION_STOP is never sent to AuxServices
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-2668
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2668
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Robert Joseph Evans
>            Assignee: Thomas Graves
>            Priority: Blocker
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2668.patch, MAPREDUCE-2668.patch
>
>
> APPLICATION_STOP is never sent to the AuxServices only APPLICATION_INIT.  
> This means that all map intermediate data will never be deleted.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to