[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124732#comment-13124732
 ] 

Chris Douglas commented on MAPREDUCE-3162:
------------------------------------------

bq. Do you think that's worse? The whole "DuplicateAppInitTransition" thing was 
very confusing to me as I first looked at the code.

The naming sounds error-ish.

bq. it makes sense that we can avoid the shell-out to the localizer on every 
container initialization - it's not super expensive but the fork isn't free 
either. In the case that a container has no new resources associated with it, 
we shouldn't need to spawn one, right?

That's true, but a better fix would lazily launch the localizer. Even if it's 
missing resources, it may not need to run if other containers are covering its 
resource set. Creating the stub is cheap.
                
> Separate application-init and container-init event types in NM's 
> ApplicationImpl FSM
> ------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3162
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3162
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: mr-3162.txt
>
>
> Currently, the ApplicationImpl receives an INIT_APPLICATION event on every 
> container initialization. Only on the first one does it really mean to init 
> the application, whereas all subsequent events are for specific containers. 
> This JIRA is to separate the events into INIT_APPLICATION, sent once and only 
> once per application, and INIT_CONTAINER, which is sent for every container. 
> The first container sends INIT_APPLICATION followed by INIT_CONTAINER.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to