[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated MAPREDUCE-3144:
-----------------------------------------------

    Status: Open  (was: Patch Available)

Sid, the patch needs minor merge to trunk, can you please do that?

I cursorily looked at the patch anyways. Few things overall:
 - The start-time is to be set by RM instead of the client, so it should not be 
part of the ApplicationSubmissionContext record?
 - ContainerId already has the ApplicationAttemptID, so we can pass ContainerId 
alone.
 - Can rename the ContainerId env to AM_CONTAINER_ID.

Looked fine overall otherwise, but will look at the patch more carefully, tests 
etc, once you put up the updated patch.

Thanks.
                
> Augment JobHistory to include information needed for serving aggregated logs.
> -----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3144
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3144
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Siddharth Seth
>            Priority: Critical
>             Fix For: 0.23.0
>
>         Attachments: MR3144.patch, MR3144_v2.txt, MR3144_v3.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to