[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129142#comment-13129142
 ] 

Chris Riccomini commented on MAPREDUCE-3068:
--------------------------------------------

Hey Arun,

Could you have a look at the patch I just put up? It uses putIfAbsent from 
sanitizeEnv -> setEnvFromInputStringIfAbsent -> addToEnvironment. That way, any 
env variables set via admin-env will only be applied if they aren't already set 
in the environment.

This should allow apps to override the variables, I believe.

I thought it was a little goofy to have putIfAbsent specifically called out for 
certain env variables and not for others, so I put them all in admin-env, and 
made all admin-env variables putIfAbsent. That way it covers both the env 
variables that you list out, as well as any other variables that someone may 
add.

Is this OK?

Cheers,
Chris
                
> Should set MALLOC_ARENA_MAX for all YARN daemons and AMs/Containers
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3068
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3068
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Chris Riccomini
>            Priority: Blocker
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-3068.diff, MAPREDUCE-3068.diff, 
> MAPREDUCE-3068.diff, MAPREDUCE-3068.diff, MAPREDUCE-3068.diff, 
> MAPREDUCE-3068.diff
>
>
> This is same as HADOOP-7154 but for yarn. RM, NM, AM and containers should 
> all have this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to